smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 23:05:04 +01:00
Code Issues Projects Releases Wiki Activity

Prevent adding routes in read-only sessions

Browse source 
"AddTrackBus" is a rec_sensitive and write_sensitive action.

However the mixer bypasses this and unconditionally calls
ARDOUR_UI::instance()->add_route () in various cases
(right-click on blank space or scroller, left-click on "Add" buttons
in the VCA pane, route pane, etc).

Since those are direct events, not related actions, they need
to be explicitly ignored.

Ideally the "+" buttons would be made insensitive...
This commit is contained in:
Robin Gareus 2020-03-17 22:30:11 +01:00
parent 45026100aa
commit 5f88cbfd39
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
gtk2_ardour/ardour_ui.cc
View file

@ -2614,12 +2614,12 @@ ARDOUR_UI::start_duplicate_routes ()
void void
ARDOUR_UI::add_route () ARDOUR_UI::add_route ()
{ {
if (!add_route_dialog.get (false)) { if (!_session || !_session->writable() || _session->actively_recording()) {
add_route_dialog->signal_response().connect (sigc::mem_fun (*this, &ARDOUR_UI::add_route_dialog_response)); return;
} }
if (!_session) { if (!add_route_dialog.get (false)) {
return; add_route_dialog->signal_response().connect (sigc::mem_fun (*this, &ARDOUR_UI::add_route_dialog_response));
} }
if (add_route_dialog->is_visible()) { if (add_route_dialog->is_visible()) {