diff --git a/libs/ardour/ardour/smf_source.h b/libs/ardour/ardour/smf_source.h index ccc03acd66..1dd993c686 100644 --- a/libs/ardour/ardour/smf_source.h +++ b/libs/ardour/ardour/smf_source.h @@ -34,7 +34,7 @@ namespace ARDOUR { template class MidiRingBuffer; /** Standard Midi File (Type 0) Source */ -class SMFSource : public MidiSource, public Evoral::SMF { +class SMFSource : public MidiSource, public Evoral::SMF { public: enum Flag { Writable = 0x1, diff --git a/libs/ardour/import.cc b/libs/ardour/import.cc index 97cebf1456..1b6d604d8f 100644 --- a/libs/ardour/import.cc +++ b/libs/ardour/import.cc @@ -309,7 +309,7 @@ write_audio_data_to_new_files (ImportableSource* source, Session::import_status& } static void -write_midi_data_to_new_files (Evoral::SMF* source, Session::import_status& status, +write_midi_data_to_new_files (Evoral::SMF* source, Session::import_status& status, vector >& newfiles) { uint32_t buf_size = 4; @@ -402,8 +402,8 @@ Session::import_audiofiles (import_status& status) p != status.paths.end() && !status.cancel; ++p, ++cnt) { - boost::shared_ptr source; - std::auto_ptr< Evoral::SMF > smf_reader; + boost::shared_ptr source; + std::auto_ptr smf_reader; const DataType type = ((*p).rfind(".mid") != string::npos) ? DataType::MIDI : DataType::AUDIO; @@ -419,7 +419,7 @@ Session::import_audiofiles (import_status& status) } else { try { - smf_reader = std::auto_ptr< Evoral::SMF >(new Evoral::SMF()); + smf_reader = std::auto_ptr(new Evoral::SMF()); smf_reader->open(*p); channels = smf_reader->num_tracks(); } catch (...) { diff --git a/libs/ardour/smf_source.cc b/libs/ardour/smf_source.cc index d55226aa69..d75c4b93d5 100644 --- a/libs/ardour/smf_source.cc +++ b/libs/ardour/smf_source.cc @@ -50,7 +50,7 @@ string SMFSource::_search_path; SMFSource::SMFSource (Session& s, std::string path, Flag flags) : MidiSource (s, region_name_from_path(path, false)) - , Evoral::SMF () + , Evoral::SMF () , _flags (Flag(flags | Writable)) // FIXME: this needs to be writable for now , _allow_remove_if_empty(true) , _last_ev_time(0) @@ -144,7 +144,7 @@ SMFSource::read_unlocked (MidiRingBuffer& dst, nframes_t start, nfram size_t scratch_size = 0; // keep track of scratch to minimize reallocs // FIXME: don't seek to start and search every read (brutal!) - Evoral::SMF::seek_to_start(); + Evoral::SMF::seek_to_start(); // FIXME: assumes tempo never changes after start const double frames_per_beat = _session.tempo_map().tempo_at(_timeline_position).frames_per_beat( @@ -153,7 +153,7 @@ SMFSource::read_unlocked (MidiRingBuffer& dst, nframes_t start, nfram const uint64_t start_ticks = (uint64_t)((start / frames_per_beat) * ppqn()); - while (!Evoral::SMF::eof()) { + while (!Evoral::SMF::eof()) { int ret = read_event(&ev_delta_t, &ev_size, &ev_buffer); if (ret == -1) { // EOF //cerr << "SMF - EOF\n"; @@ -250,7 +250,7 @@ SMFSource::write_unlocked (MidiRingBuffer& src, nframes_t cnt) set_default_controls_interpolation(); } - Evoral::SMF::flush(); + Evoral::SMF::flush(); free(buf); const nframes_t oldlen = _length; @@ -300,7 +300,7 @@ SMFSource::append_event_unlocked(EventTimeUnit unit, const Evoral::Event delta_time = (uint32_t)((ev.time() - last_event_time()) * ppqn()); } - Evoral::SMF::append_event_delta(delta_time, ev.size(), ev.buffer()); + Evoral::SMF::append_event_delta(delta_time, ev.size(), ev.buffer()); _last_ev_time = ev.time(); _write_data_count += ev.size(); @@ -356,7 +356,7 @@ void SMFSource::mark_streaming_midi_write_started (NoteMode mode, nframes_t start_frame) { MidiSource::mark_streaming_midi_write_started (mode, start_frame); - Evoral::SMF::begin_write (); + Evoral::SMF::begin_write (); _last_ev_time = 0; } @@ -370,7 +370,7 @@ SMFSource::mark_streaming_write_completed () } _model->set_edited(false); - Evoral::SMF::end_write (); + Evoral::SMF::end_write (); } void @@ -634,7 +634,7 @@ SMFSource::load_model(bool lock, bool force_reload) } _model->start_write(); - Evoral::SMF::seek_to_start(); + Evoral::SMF::seek_to_start(); uint64_t time = 0; /* in SMF ticks */ Evoral::Event ev; @@ -706,6 +706,6 @@ SMFSource::destroy_model() void SMFSource::flush_midi() { - Evoral::SMF::end_write(); + Evoral::SMF::end_write(); } diff --git a/libs/evoral/evoral/SMF.hpp b/libs/evoral/evoral/SMF.hpp index 14046ab8f3..73d56e5eaa 100644 --- a/libs/evoral/evoral/SMF.hpp +++ b/libs/evoral/evoral/SMF.hpp @@ -29,15 +29,11 @@ typedef smf_track_struct smf_track_t; namespace Evoral { -template class Event; -template class EventRingBuffer; - -#define THROW_FILE_ERROR throw(typename SMF