smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-30 10:27:44 +01:00
Code Issues Projects Releases Wiki Activity

Fix touching mute automation (mostly)

Browse source 
controllable->set_value() from GUI context will eventually queue
a session-rt command. By the time the realtime command runs, the
controllable needs to be in "touch" mode.

The AutomationController "toggle" UI worked around this by directly using
the underlying API (ignoring slaved-controls and ignoring groups).
The RouteUI's GUI wasn't able to write mute-automation at all.

This commit is a compromise: press + hold (touch) + release button.

(it may need further special-casing for _desc.toggled in
AutomationControl::actually_set_value(), also undoing automation-writes
is currently  not working correctly)
This commit is contained in:
Robin Gareus 2017-02-28 04:59:45 +01:00
parent 1071c0e788
commit 5c4a2025f1
3 changed files with 27 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

3
gtk2_ardour/automation_controller.h
View file

@ -86,7 +86,8 @@ private:
void start_touch();
void end_touch();
void toggled();
bool button_press(GdkEventButton*);
bool button_release(GdkEventButton*);
void run_note_select_dialog();
void set_ratio(double ratio);