smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 08:36:32 +01:00
Code Issues Projects Releases Wiki Activity

Fix double toggle on repeat call of on_button_release_event

Browse source 
This can happen with touch screens.. leading to
`set_active (!get_active ());` being called twice, and effective NOOP.
This commit is contained in:
Robin Gareus 2025-04-15 21:48:42 +02:00
parent d0a5bff06e
commit 5a90eb0776
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
libs/widgets/ardour_button.cc
View file

@ -1082,10 +1082,10 @@ ArdourButton::on_button_release_event (GdkEventButton *ev)
return true; return true;
} }
_grabbed = false;
CairoWidget::set_dirty (); CairoWidget::set_dirty ();
if (ev->button == 1 && _hovering) { if (ev->button == 1 && _hovering && _grabbed) {
_grabbed = false;
if (_act_on_release && _auto_toggle && !_action) { if (_act_on_release && _auto_toggle && !_action) {
set_active (!get_active ()); set_active (!get_active ());
} }
@ -1098,6 +1098,8 @@ ArdourButton::on_button_release_event (GdkEventButton *ev)
} }
} }
_grabbed = false;
return _fallthrough_to_parent ? false : true; return _fallthrough_to_parent ? false : true;
} }