smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 14:54:56 +01:00
Code Issues Projects Releases Wiki Activity

Remove drag code from automation region view.

Browse source 
Let the editor handle it like (almost) everything else.
This commit is contained in:
David Robillard 2015-01-13 23:53:28 -05:00
parent d39d4c1c11
commit 59bb3fbe65
2 changed files with 12 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

28
gtk2_ardour/automation_region_view.cc
View file

@ -132,30 +132,10 @@ AutomationRegionView::canvas_group_event (GdkEvent* ev)
PublicEditor& e = trackview.editor (); PublicEditor& e = trackview.editor ();
if (!trackview.editor().internal_editing()) { if (trackview.editor().internal_editing() &&
// not in internal edit mode, so just act like a normal region ev->type == GDK_BUTTON_RELEASE &&
return RegionView::canvas_group_event (ev); e.current_mouse_mode() == Editing::MouseDraw &&
} !e.drags()->active()) {
if (ev->type == GDK_BUTTON_PRESS && e.current_mouse_mode() == Editing::MouseContent) {
/* XXX: icky dcast to Editor */
e.drags()->set (new EditorRubberbandSelectDrag (dynamic_cast<Editor*> (&e), group), ev);
e.drags()->start_grab (ev);
return true;
} else if (ev->type == GDK_MOTION_NOTIFY && e.drags()->active()) {
/* we probably shouldn't have to handle this here, but... */
e.drags()->motion_handler(ev, false);
return true;
} else if (ev->type == GDK_BUTTON_RELEASE && e.current_mouse_mode() == Editing::MouseDraw) {
if (e.drags()->end_grab (ev)) {
return true;
} else if (e.current_mouse_mode() != Editing::MouseDraw &&
e.current_mouse_mode() != Editing::MouseContent) {
return RegionView::canvas_group_event (ev);
}
double x = ev->button.x; double x = ev->button.x;
double y = ev->button.y; double y = ev->button.y;

8
gtk2_ardour/editor_mouse.cc
View file

@ -750,6 +750,14 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
return true; return true;
break; break;
case RegionItem:
if (dynamic_cast<AutomationRegionView*>(clicked_regionview)) {
/* rubberband drag to select automation points */
_drags->set (new EditorRubberbandSelectDrag (this, item), event);
return true;
}
break;
default: default:
break; break;
} }