re-add plugin bypass state and move proc order writing closer to top

scripts/_store_recall_mixer.lua

@@ -10,7 +10,7 @@ function factory() return function()
     local path = ARDOUR.LuaAPI.build_filename(Session:path(), "export", "params.lua")
     function mark()
         local file = io.open(path, "w")
-        file:write("") --empty curent file from last run
+        file:write("") --empty current file from last run
         file:close()
         for r in Session:get_routes():iter() do
             if r:is_monitor () or r:is_auditioner () then goto nextroute end -- skip special routes
@@ -25,6 +25,23 @@ function factory() return function()
                 x = x + 1
             until proc:isnil()
 
+            local route_str, proc_order_str = "", ""
+            local rid = r:to_stateful():id():to_s()
+            local pan = r:pan_azimuth_control()
+            if pan:isnil() then pan = false else pan = pan:get_value() end --sometimes a route doesn't have pan, like the master.
+
+            local on = 0
+            for p in order:iter() do
+                local pid = p:to_stateful():id():to_s()
+                proc_order_str = proc_order_str .. "[" .. on .. "] = " .. pid ..","
+                on = on + 1
+            end
+
+            route_str = "instance = {route_id = " .. rid .. ", gain_control = " .. r:gain_control():get_value() .. ", trim_control = " .. r:trim_control():get_value() .. ", pan_control = " .. tostring(pan) .. ", order = {" .. proc_order_str .."}" .. "}"
+            file = io.open(path, "a")
+            file:write(route_str, "\r\n")
+            file:close()
+
             local i = 0
             while true do
                 local params = {}
@@ -57,25 +74,7 @@ function factory() return function()
                 file:write(proc_str, "\r\n")
                 file:close()
             end
-
-        local route_str, proc_order_str = "", ""
-        local rid = r:to_stateful():id():to_s()
-        local pan = r:pan_azimuth_control()
-        if pan:isnil() then pan = false else pan = pan:get_value() end --sometimes a route doesn't have pan, like the master.
-
-        local on = 0
-        for p in order:iter() do
-            local pid = p:to_stateful():id():to_s()
-            proc_order_str = proc_order_str .. "[" .. on .. "] = " .. pid ..","
-            on = on + 1
-        end
-
-        route_str = "instance = {route_id = " .. rid .. ", gain_control = " .. r:gain_control():get_value() .. ", trim_control = " .. r:trim_control():get_value() .. ", pan_control = " .. tostring(pan) .. ", order = {" .. proc_order_str .."}" .. "}"
-        file = io.open(path, "a")
-        file:write(route_str, "\r\n")
-        file:close()
             ::nextroute::
-
         end
     end
 
@@ -101,7 +100,7 @@ function factory() return function()
                 local rid = PBD.ID(instance["route_id"])
                 local rt = Session:route_by_id(rid)
                 if rt:isnil() then goto nextline end
-            local gc, tc, pc, act = instance["gain_control"], instance["trim_control"], instance["pan_control"], instance["active"]
+                local gc, tc, pc = instance["gain_control"], instance["trim_control"], instance["pan_control"]
                 rt:gain_control():set_value(gc, 1)
                 rt:trim_control():set_value(tc, 1)
                 if pc ~= false then rt:pan_azimuth_control():set_value(pc, 1) end
@@ -109,15 +108,16 @@ function factory() return function()
             end
 
             if plugin then
+                local act = instance["active"]
                 local id = PBD.ID(instance["plugin_id"])
                 local proc = Session:processor_by_id(id)
                 if proc:isnil() then goto nextline end
                 for k, v in pairs(instance["parameters"]) do
                     ARDOUR.LuaAPI.set_processor_param(proc, k, v)
                 end
+                if act then proc:activate() else proc:deactivate() end
             end
             ::nextline::
-        instance = nil
         end
     end
 
@@ -128,7 +128,7 @@ function factory() return function()
     }
 
     local rv = LuaDialog.Dialog("Mixer Store:", dialog_options):run()
-    assert(rv, 'Dialog box was cancelled or is ' .. type(rv))
+    assert(rv, 'Dialog box was canceled or is ' .. type(rv))
     local c = rv["select"]
     if c == "mark" then mark() end
     if c == "recall" then recall() end