smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 00:34:59 +01:00
Code Issues Projects Releases Wiki Activity

do not sort lineset every time a coord is added; use RAII to create scope and sort at end

Browse source
This commit is contained in:
Paul Davis 2023-04-09 14:34:22 -06:00
parent d4bca18108
commit 4f87506e5c
4 changed files with 29 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
libs/canvas/canvas/line_set.h
View file

@ -47,6 +47,15 @@ public:
void set_extent (Distance);
Distance extent() const { return _extent; }
void begin_add ();
void end_add ();
struct ResetRAII {
ResetRAII (LineSet& l) : lines (l) { lines.clear(); lines.begin_add(); }
~ResetRAII () { lines.end_add (); }
LineSet& lines;
};
void add_coord (Coord, Distance, Gtkmm2ext::Color);
void clear ();

17
libs/canvas/line_set.cc
View file

@ -131,12 +131,23 @@ LineSet::render (Rect const & area, Cairo::RefPtr<Cairo::Context> context) const
}
void
LineSet::add_coord (Coord y, Distance width, Gtkmm2ext::Color color)
LineSet::add_coord (Coord pos, Distance width, Gtkmm2ext::Color color)
{
_lines.push_back (Line (pos, width, color));
}
void
LineSet::begin_add ()
{
begin_change ();
}
_lines.push_back (Line (y, width, color));
sort (_lines.begin(), _lines.end(), LineSorter());
void
LineSet::end_add ()
{
if (!_lines.empty()) {
sort (_lines.begin(), _lines.end(), LineSorter());
}
set_bbox_dirty ();
end_change ();