From 4bbfb6ce50e0de3db879f605d7afccfe4f89f458 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Mon, 26 Nov 2018 00:32:29 +0100 Subject: [PATCH] Fix a double-free, introduced in b06713bd8e57 ~OptionEditor() already frees all components on every page. --- gtk2_ardour/session_option_editor.cc | 7 ------- gtk2_ardour/session_option_editor.h | 1 - 2 files changed, 8 deletions(-) diff --git a/gtk2_ardour/session_option_editor.cc b/gtk2_ardour/session_option_editor.cc index 0ffb4c14d7..362d28cce4 100644 --- a/gtk2_ardour/session_option_editor.cc +++ b/gtk2_ardour/session_option_editor.cc @@ -408,13 +408,6 @@ SessionOptionEditor::SessionOptionEditor (Session* s) set_current_page (_("Timecode")); } -SessionOptionEditor::~SessionOptionEditor () -{ - delete _vpu; - delete _sf; - delete _take_name; -} - void SessionOptionEditor::parameter_changed (std::string const & p) { diff --git a/gtk2_ardour/session_option_editor.h b/gtk2_ardour/session_option_editor.h index bf373c8f33..81d72df731 100644 --- a/gtk2_ardour/session_option_editor.h +++ b/gtk2_ardour/session_option_editor.h @@ -31,7 +31,6 @@ class SessionOptionEditor : public OptionEditorWindow { public: SessionOptionEditor (ARDOUR::Session* s); - ~SessionOptionEditor (); private: void parameter_changed (std::string const &);