smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-19 05:06:31 +01:00
Code Issues Projects Releases Wiki Activity

Fix some recursive undo removal

Browse source 
~StatefulDiffCommand() may trigger UndoTransaction::command_death()
which may delete the StatefulDiffCommand() that's just being destroyed.

This depends on the signal-connection order, which is undefined.
In any case when a shared_ptr<> object is being destroyed it means
that all references to it are already gone. There's no need to
emit drop_references from the d'tor.
This commit is contained in:
Robin Gareus 2020-02-28 06:06:44 +01:00
parent bf3a36a126
commit 4b28e4ee3c
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
2 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
libs/pbd/pbd/memento_command.h
View file

@ -120,7 +120,6 @@ public:
} }
~MementoCommand () { ~MementoCommand () {
drop_references ();
delete before; delete before;
delete after; delete after;
delete _binder; delete _binder;

2
libs/pbd/stateful_diff_command.cc
View file

@ -68,8 +68,6 @@ StatefulDiffCommand::StatefulDiffCommand (boost::shared_ptr<StatefulDestructible
StatefulDiffCommand::~StatefulDiffCommand () StatefulDiffCommand::~StatefulDiffCommand ()
{ {
drop_references ();
delete _changes; delete _changes;
} }