From 4826a90796f601b0e198269251ebb8858141f719 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Mon, 18 Aug 2025 19:04:05 -0600 Subject: [PATCH] prefs editing widgets for region-edit-disposition --- gtk2_ardour/editor_mouse.cc | 6 +++++- gtk2_ardour/rc_option_editor.cc | 17 +++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/gtk2_ardour/editor_mouse.cc b/gtk2_ardour/editor_mouse.cc index f3aaddc348..09d956b624 100644 --- a/gtk2_ardour/editor_mouse.cc +++ b/gtk2_ardour/editor_mouse.cc @@ -1921,7 +1921,11 @@ Editor::edit_region (RegionView* rv) break; case Editing::OpenBottomPane: if (!att_bottom_visible()) { - /* XXX do something */ + Glib::RefPtr act = bottom_attachment_button.get_related_action(); + Glib::RefPtr tact = Glib::RefPtr::cast_dynamic(act); + if (tact) { + tact->set_active (true); + } } maybe_edit_region_in_bottom_pane (*rv); break; diff --git a/gtk2_ardour/rc_option_editor.cc b/gtk2_ardour/rc_option_editor.cc index 24fb1cfb1c..56a61d7f81 100644 --- a/gtk2_ardour/rc_option_editor.cc +++ b/gtk2_ardour/rc_option_editor.cc @@ -3421,6 +3421,23 @@ These settings will only take effect after %1 is restarted.\n\ 1, 10 )); + add_option (_("Editor"), new OptionEditorHeading (_("Region Editing"))); + ComboOption* red = new ComboOption ( + "region-edit-disposition", + _("Region Editing Preference"), + sigc::mem_fun (UIConfiguration::instance(), + &UIConfiguration::get_region_edit_disposition), + sigc::mem_fun (UIConfiguration::instance(), + &UIConfiguration::set_region_edit_disposition) + ); + + red->add (Editing::BottomPaneOnly, _("Only ever use the bottom pane")); + red->add (Editing::OpenBottomPane, _("Open bottom pane, if necessary")); + red->add (Editing::PreferBottomPane, _("Use bottom pane if visible, or own window")); + red->add (Editing::BottomPaneOnly, _("Always use a separate window")); + + add_option (_("Editor"), red); + add_option (_("Editor/Snap"), new BoolOption ( "show-snapped-cursor",