smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-07 07:14:56 +01:00
Code Issues Projects Releases Wiki Activity

PBD::Signal<...>::connect() is already thread safe, so drop intermediate proxy/call_slot() invocation in handling Controllable::Changed within AutomationController

Browse source
This commit is contained in:
Paul Davis 2017-02-21 18:45:16 +01:00
parent 81bbeb51ea
commit 419006dd83
2 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
gtk2_ardour/automation_controller.cc
View file

@ -120,7 +120,7 @@ AutomationController::AutomationController(boost::shared_ptr<Automatable>
_screen_update_connection = Timers::rapid_connect ( _screen_update_connection = Timers::rapid_connect (
sigc::mem_fun (*this, &AutomationController::display_effective_value)); sigc::mem_fun (*this, &AutomationController::display_effective_value));
ac->Changed.connect (_changed_connection, invalidator (*this), boost::bind (&AutomationController::value_changed, this), gui_context()); ac->Changed.connect (_changed_connection, invalidator (*this), boost::bind (&AutomationController::display_effective_value, this), gui_context());
add(*_widget); add(*_widget);
show_all(); show_all();
@ -334,12 +334,6 @@ AutomationController::on_button_release(GdkEventButton* ev)
return false; return false;
} }
void
AutomationController::value_changed ()
{
Gtkmm2ext::UI::instance()->call_slot (invalidator (*this), boost::bind (&AutomationController::display_effective_value, this));
}
/** Stop updating our value from our controllable */ /** Stop updating our value from our controllable */
void void
AutomationController::stop_updating () AutomationController::stop_updating ()

2
gtk2_ardour/automation_controller.h
View file

@ -93,8 +93,6 @@ private:
void set_freq_beats(double beats); void set_freq_beats(double beats);
bool on_button_release(GdkEventButton* ev); bool on_button_release(GdkEventButton* ev);
void value_changed();
Gtk::Widget* _widget; Gtk::Widget* _widget;
boost::shared_ptr<ARDOUR::Automatable> _printer; boost::shared_ptr<ARDOUR::Automatable> _printer;
boost::shared_ptr<ARDOUR::AutomationControl> _controllable; boost::shared_ptr<ARDOUR::AutomationControl> _controllable;