smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-06 14:54:56 +01:00
Code Issues Projects Releases Wiki Activity

Hardcode pitch-shift algorithm (for now)

Browse source 
This fixes an issue with pitch-shift using the most recently used
time-stretch algorithm, which may be "resample.." (effective NO-OP).

Also leave a ToDo note regarding rubberband crispness levels for later.
This commit is contained in:
Robin Gareus 2018-07-23 18:13:41 +02:00
parent 92a685495c
commit 3324c95687
1 changed files with 25 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

26
gtk2_ardour/editor_timefx.cc
View file

@ -208,7 +208,31 @@ Editor::time_fx (RegionList& regions, float val, bool pitching)
} }
} }
switch (rb_current_opt) { int rb_mode = rb_current_opt;
if (pitching /*&& rb_current_opt == 6*/) {
/* The timefx dialog does not show the "stretch_opts_selector"
* when pitch-shifting. So the most recently used option from
* "Time Stretch" would be used (if any). That may even be
* "resample without preserving pitch", which would be invalid.
*
* TODO: also show stretch_opts_selector when pitching (except the option
* to not preserve pitch) and use separate rb_current_opt when pitching.
*
* Actually overhaul this the dialog and processing opts below and use rubberband's
* "Crispness" levels:
* -c 0 equivalent to --no-transients --no-lamination --window-long
* -c 1 equivalent to --detector-soft --no-lamination --window-long (for piano)
* -c 2 equivalent to --no-transients --no-lamination
* -c 3 equivalent to --no-transients
* -c 4 equivalent to --bl-transients
* -c 5 default processing options
* -c 6 equivalent to --no-lamination --window-short (may be good for drums)
*/
rb_mode = 4;
}
switch (rb_mode) {
case 0: case 0:
transients = NoTransients; peaklock = false; longwin = true; shortwin = false; transients = NoTransients; peaklock = false; longwin = true; shortwin = false;
break; break;