smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 16:46:35 +01:00
Code Issues Projects Releases Wiki Activity

PatchChange: fix operator=() implementation which failed to manage event buffer ownership correctly

Browse source
This commit is contained in:
Paul Davis 2022-02-02 15:03:12 -07:00
parent 6175af002c
commit 31f4d8a2ca
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
libs/evoral/evoral/PatchChange.h
View file

@ -74,6 +74,15 @@ public:
unset (); unset ();
} }
PatchChange& operator= (PatchChange const & other) {
/* Need to be careful with assignment here, due to buffer
ownership issues etc.
*/
_bank_change_msb.set (other._bank_change_msb.buffer(), 3, other.time());
_bank_change_lsb.set (other._bank_change_lsb.buffer(), 3, other.time());
_program_change.set (other._program_change.buffer(), 2, other.time());
return *this;
}
void unset() { void unset() {
_bank_change_msb.buffer()[1] = 0xf; /* unset */ _bank_change_msb.buffer()[1] = 0xf; /* unset */
_bank_change_lsb.buffer()[1] = 0xf; /* unset */ _bank_change_lsb.buffer()[1] = 0xf; /* unset */