smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 00:34:59 +01:00
Code Issues Projects Releases Wiki Activity

Cleanup various design patterns.

Browse source 
* do not use implicit bool-to-int-cast
* avoid C++11 member initialization in header
* always use set and access methods, remove public variable
This commit is contained in:
Robin Gareus 2018-08-24 16:53:06 +02:00
parent c46cd91d0e
commit 3136b20847
4 changed files with 22 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

9
libs/surfaces/launch_control_xl/gui.cc
View file

@ -134,7 +134,7 @@ LCXLGUI::LCXLGUI (LaunchControlXL& p)
align->set (0.0, 0.5);
align->add (fader8master_button);
table.attach (*align, 1, 2, row, row+1, AttachOptions(FILL|EXPAND), AttachOptions (0),0,0);
fader8master_button.set_active(lcxl.use_fader8master);
fader8master_button.set_active (lcxl.fader8master());
fader8master_button.signal_toggled().connect (sigc::mem_fun (*this, &LCXLGUI::toggle_fader8master));
row++;
@ -285,8 +285,7 @@ LCXLGUI::active_port_changed (Gtk::ComboBox* combo, bool for_input)
void
LCXLGUI::toggle_fader8master ()
{
DEBUG_TRACE(DEBUG::LaunchControlXL, string_compose("use_fader8master WAS: %1\n", lcxl.use_fader8master));
lcxl.use_fader8master = !(lcxl.use_fader8master);
DEBUG_TRACE(DEBUG::LaunchControlXL, string_compose("use_fader8master IS: %1\n", lcxl.use_fader8master));
lcxl.set_fader8master(lcxl.use_fader8master);
DEBUG_TRACE(DEBUG::LaunchControlXL, string_compose("use_fader8master WAS: %1\n", lcxl.fader8master()));
lcxl.set_fader8master (!lcxl.fader8master());
DEBUG_TRACE(DEBUG::LaunchControlXL, string_compose("use_fader8master IS: %1\n", lcxl.fader8master()));
}