From 2bf9014ba194009dfc37eb7f15e4f70379587bdb Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Sun, 7 Feb 2021 00:04:36 +0100 Subject: [PATCH] Fix crash when detaching Editor or Mixer w/o session Mixer_UI::show_window(), Editor::use_own_window() use `show_all()` and the fixup items that should be invisible. This involves a call to `parameter_changed ("show-group-tabs");` --- gtk2_ardour/editor_actions.cc | 2 +- gtk2_ardour/mixer_ui.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gtk2_ardour/editor_actions.cc b/gtk2_ardour/editor_actions.cc index f9ca182529..39adddb42e 100644 --- a/gtk2_ardour/editor_actions.cc +++ b/gtk2_ardour/editor_actions.cc @@ -1428,7 +1428,7 @@ Editor::parameter_changed (std::string p) } } else if (p == "show-group-tabs") { - bool const s = _session->config.get_show_group_tabs (); + bool const s = _session ? _session->config.get_show_group_tabs () : true; if (s) { _group_tabs->show (); } else { diff --git a/gtk2_ardour/mixer_ui.cc b/gtk2_ardour/mixer_ui.cc index c8ae5f8a7e..08cbfa4dc6 100644 --- a/gtk2_ardour/mixer_ui.cc +++ b/gtk2_ardour/mixer_ui.cc @@ -2784,7 +2784,7 @@ void Mixer_UI::parameter_changed (string const & p) { if (p == "show-group-tabs") { - bool const s = _session->config.get_show_group_tabs (); + bool const s = _session ? _session->config.get_show_group_tabs () : true; if (s) { _group_tabs->show (); } else {