From 50e8c4d5298e4786f7a4c751ad6fbf87ef8e8da2 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Mon, 1 Apr 2019 22:28:07 +0200 Subject: [PATCH 1/4] Expose Latch automation mode to MCUs --- libs/surfaces/mackie/mackie_control_protocol.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libs/surfaces/mackie/mackie_control_protocol.cc b/libs/surfaces/mackie/mackie_control_protocol.cc index ba99737283..c43483a7ba 100755 --- a/libs/surfaces/mackie/mackie_control_protocol.cc +++ b/libs/surfaces/mackie/mackie_control_protocol.cc @@ -2016,6 +2016,14 @@ MackieControlProtocol::update_fader_automation_state () update_global_button (Button::Latch, off); update_global_button (Button::Grp, off); break; + case Latch: + update_global_button (Button::Read, off); + update_global_button (Button::Write, off); + update_global_button (Button::Touch, off); + update_global_button (Button::Trim, off); + update_global_button (Button::Latch, on); + update_global_button (Button::Grp, off); + break; } } From 6d335be41835ebd7ed3e0846c235623b79e055ba Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Mon, 1 Apr 2019 22:30:16 +0200 Subject: [PATCH 2/4] Indicate automation-latch as "touch" on the FP1 The FP1 does not have a dedicated "Latch" control, but this does at least consistently indicate that Touch, rather than show some arbitrary LED state. --- libs/surfaces/faderport/faderport.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/surfaces/faderport/faderport.cc b/libs/surfaces/faderport/faderport.cc index ed2393e0e2..da2792dbd5 100644 --- a/libs/surfaces/faderport/faderport.cc +++ b/libs/surfaces/faderport/faderport.cc @@ -1199,6 +1199,7 @@ FaderPort::map_auto () get_button (FP_Touch).set_led_state (_output_port, false); break; case ARDOUR::Touch: + case ARDOUR::Latch: // XXX get_button (FP_Read).set_led_state (_output_port, false); get_button (FP_Write).set_led_state (_output_port, false); get_button (FP_Touch).set_led_state (_output_port, true); From 8f5e5c4c604165135d4bc2cbc8e882acf03c0afb Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Tue, 2 Apr 2019 01:51:36 +0200 Subject: [PATCH 3/4] Downgrade LADSPA scan errors to warnings There's nothing that a casual user can about failure to scan LADSPA plugins. So just inform the user. It's not an error to worry about. --- libs/ardour/ladspa_plugin.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/ardour/ladspa_plugin.cc b/libs/ardour/ladspa_plugin.cc index 30b0bad11d..2feb329bb4 100644 --- a/libs/ardour/ladspa_plugin.cc +++ b/libs/ardour/ladspa_plugin.cc @@ -91,27 +91,27 @@ LadspaPlugin::init (string module_path, uint32_t index, samplecnt_t rate) _was_activated = false; if (!(*_module)) { - error << _("LADSPA: Unable to open module: ") << Glib::Module::get_last_error() << endmsg; + warning << _("LADSPA: Unable to open module: ") << Glib::Module::get_last_error() << endmsg; delete _module; throw failed_constructor(); } if (!_module->get_symbol("ladspa_descriptor", func)) { - error << _("LADSPA: module has no descriptor function.") << endmsg; + warning << _("LADSPA: module has no descriptor function.") << endmsg; throw failed_constructor(); } dfunc = (LADSPA_Descriptor_Function)func; if ((_descriptor = dfunc (index)) == 0) { - error << _("LADSPA: plugin has gone away since discovery!") << endmsg; + warning << _("LADSPA: plugin has gone away since discovery!") << endmsg; throw failed_constructor(); } _index = index; if (LADSPA_IS_INPLACE_BROKEN(_descriptor->Properties)) { - error << string_compose(_("LADSPA: \"%1\" cannot be used, since it cannot do inplace processing"), _descriptor->Name) << endmsg; + info << string_compose(_("LADSPA: \"%1\" cannot be used, since it cannot do inplace processing"), _descriptor->Name) << endmsg; throw failed_constructor(); } From 6f95dfdc319fa6952563f1a2ad2571a1c51b7da4 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Tue, 2 Apr 2019 15:35:57 +0200 Subject: [PATCH 4/4] Fix MIDI Aftertouch (import, record and play) in the backend --- libs/evoral/src/Sequence.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/evoral/src/Sequence.cpp b/libs/evoral/src/Sequence.cpp index b94ac088f5..99d5d1448c 100644 --- a/libs/evoral/src/Sequence.cpp +++ b/libs/evoral/src/Sequence.cpp @@ -949,7 +949,8 @@ Sequence