From 22acbc1cee1386baff3929e027231a6d8a2159e4 Mon Sep 17 00:00:00 2001 From: Tim Mayberry Date: Tue, 11 Aug 2015 14:20:43 +1000 Subject: [PATCH] Fix to ensure there are always sample rates and buffer sizes in the dropdown This can happen if both input and output devices are set to None for instance on backends that report no supported SR or buffer size for the None device. --- gtk2_ardour/engine_dialog.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gtk2_ardour/engine_dialog.cc b/gtk2_ardour/engine_dialog.cc index d3c1e14d08..01450ecb0b 100644 --- a/gtk2_ardour/engine_dialog.cc +++ b/gtk2_ardour/engine_dialog.cc @@ -1172,6 +1172,11 @@ EngineControl::set_samplerate_popdown_strings () if (_have_control) { sr = get_sample_rates_for_all_devices (); + // currently possible if both devices are set to "None" and the backend + // returns no supported rates for both devices + if (sr.empty()) { + sr = get_default_sample_rates (); + } } else { sr = get_default_sample_rates (); } @@ -1257,6 +1262,11 @@ EngineControl::set_buffersize_popdown_strings () if (_have_control) { bs = get_buffer_sizes_for_all_devices (); + // currently possible if both devices are set to "None" and the backend + // returns no supported sizes for both devices + if (bs.empty()) { + bs = get_default_buffer_sizes (); + } } else if (backend->can_change_buffer_size_when_running()) { bs = get_default_buffer_sizes (); }