smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-07 15:25:01 +01:00
Code Issues Projects Releases Wiki Activity

RegionFX: handle property and non-automatable controls

Browse source 
This fixes crashes in recent LSP.lv2 and similar plugins.
This commit is contained in:
Robin Gareus 2025-09-26 20:27:56 +02:00
parent 82bdb3f05f
commit 215d59e0e6
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
libs/ardour/region_fx_plugin.cc
View file

@ -593,6 +593,9 @@ RegionFxPlugin::set_default_automation (timepos_t end)
{ {
for (auto const& i : _controls) { for (auto const& i : _controls) {
std::shared_ptr<AutomationControl> ac = std::dynamic_pointer_cast<AutomationControl> (i.second); std::shared_ptr<AutomationControl> ac = std::dynamic_pointer_cast<AutomationControl> (i.second);
if (!ac->alist ()) {
continue;
}
if (ac->alist ()->empty ()) { if (ac->alist ()->empty ()) {
ac->alist ()->fast_simple_add (timepos_t (time_domain ()), ac->normal ()); ac->alist ()->fast_simple_add (timepos_t (time_domain ()), ac->normal ());
ac->alist ()->fast_simple_add (end, ac->normal ()); ac->alist ()->fast_simple_add (end, ac->normal ());
@ -807,7 +810,9 @@ RegionFxPlugin::flush ()
} }
for (auto const& i : _controls) { for (auto const& i : _controls) {
shared_ptr<TimedPluginControl> tpc = std::dynamic_pointer_cast<TimedPluginControl>(i.second); shared_ptr<TimedPluginControl> tpc = std::dynamic_pointer_cast<TimedPluginControl>(i.second);
tpc->flush (); if (tpc) {
tpc->flush ();
}
} }
} }
@ -1448,7 +1453,7 @@ RegionFxPlugin::connect_and_run (BufferSet& bufs, samplepos_t start, samplepos_t
for (auto const& i : _controls) { for (auto const& i : _controls) {
shared_ptr<TimedPluginControl> tpc = std::dynamic_pointer_cast<TimedPluginControl>(i.second); shared_ptr<TimedPluginControl> tpc = std::dynamic_pointer_cast<TimedPluginControl>(i.second);
if (tpc->automation_playback ()) { if (tpc && tpc->automation_playback ()) {
tpc->store_value (start + pos, end + pos); tpc->store_value (start + pos, end + pos);
} }
} }
@ -1480,7 +1485,7 @@ RegionFxPlugin::maybe_emit_changed_signals () const
Glib::Threads::Mutex::Lock lp (_process_lock); Glib::Threads::Mutex::Lock lp (_process_lock);
for (auto const& i : _controls) { for (auto const& i : _controls) {
shared_ptr<TimedPluginControl> tpc = std::dynamic_pointer_cast<TimedPluginControl>(i.second); shared_ptr<TimedPluginControl> tpc = std::dynamic_pointer_cast<TimedPluginControl>(i.second);
if (tpc->automation_playback ()) { if (tpc && tpc->automation_playback ()) {
tpc->maybe_emit_changed (); tpc->maybe_emit_changed ();
} }
} }