smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-30 08:53:08 +01:00
Code Issues Projects Releases Wiki Activity

Create new Groups with a consistent set of default properties.

Browse source 
This is part of a larger fix for #6450. Previously new route groups were
created with different default properties depending on which code created
the new group. The group tab method had all properties set and that is now
going to be the default for all other methods (mixer strip button, etc).
This commit is contained in:
Todd Naugle 2015-09-21 14:52:25 -05:00
parent 233c144c2c
commit 203a72f883
4 changed files with 0 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gtk2_ardour/add_route_dialog.cc
View file

@ -531,11 +531,6 @@ AddRouteDialog::group_changed ()
{
if (_session && route_group_combo.get_active_text () == _("New Group...")) {
RouteGroup* g = new RouteGroup (*_session, "");
PropertyList plist;
plist.add (Properties::active, true);
g->apply_changes (plist);
RouteGroupDialog d (g, true);
if (d.do_run ()) {

25
gtk2_ardour/group_tabs.cc
View file

@ -395,32 +395,10 @@ GroupTabs::new_from_soloed ()
run_new_group_dialog (soloed);
}
PBD::PropertyList
GroupTabs::default_properties () const
{
PBD::PropertyList plist;
plist.add (Properties::route_active, true);
plist.add (Properties::active, true);
plist.add (Properties::gain, true);
plist.add (Properties::relative, true);
plist.add (Properties::color, true);
plist.add (Properties::monitoring, true);
plist.add (Properties::select, true);
plist.add (Properties::mute, true);
plist.add (Properties::solo, true);
plist.add (Properties::gain, true);
plist.add (Properties::recenable, true);
return plist;
}
void
GroupTabs::run_new_group_dialog (RouteList const & rl)
{
RouteGroup* g = new RouteGroup (*_session, "");
g->apply_changes (default_properties ());
RouteGroupDialog d (g, true);
if (d.do_run ()) {
@ -437,9 +415,6 @@ RouteGroup *
GroupTabs::create_and_add_group () const
{
RouteGroup* g = new RouteGroup (*_session, "");
g->apply_changes (default_properties ());
RouteGroupDialog d (g, true);
if (d.do_run ()) {

1
gtk2_ardour/group_tabs.h
View file

@ -91,7 +91,6 @@ private:
virtual double extent () const = 0;
virtual void add_menu_items (Gtk::Menu *, ARDOUR::RouteGroup *) {}
virtual PBD::PropertyList default_properties () const;
virtual ARDOUR::RouteList selected_routes () const = 0;
virtual void sync_order_keys () = 0;

2
gtk2_ardour/route_group_menu.cc
View file

@ -158,8 +158,6 @@ RouteGroupMenu::new_group ()
}
RouteGroup* g = new RouteGroup (*_session, "");
g->apply_changes (*_default_properties);
RouteGroupDialog d (g, true);
if (d.do_run ()) {