smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-23 07:06:23 +01:00
Code Issues Projects Releases Wiki Activity

remove useless test, fgets() already ensures MAX_STRING_LEN

Browse source 
Found by PVS-Studio - https://www.viva64.com/en/b/0540/
This commit is contained in:
Robin Gareus 2017-11-23 09:56:57 +01:00
parent 2fec64f0bd
commit 1a46ee716d
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
libs/ardour/vst_info_file.cc
View file

@ -259,14 +259,14 @@ read_string (FILE *fp)
return 0;
}
if (strlen (buf) < MAX_STRING_LEN) {
if (strlen (buf)) {
buf[strlen (buf)-1] = 0;
}
if (strlen (buf)) {
/* strip lash char here: '\n',
* since VST-params cannot be longer than 127 chars.
*/
buf[strlen (buf)-1] = 0;
return strdup (buf);
} else {
return 0;
}
return 0;
}
/** Read an integer value from a line in fp into n,