smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-06 05:35:47 +01:00
Code Issues Projects Releases Wiki Activity

LV2: fix port/nth-parameter confusion

Browse source 
various LV2 callbacks from plugin DSP/GUI use raw port_index,
not nth_parameter. This lead to incorrectly queued updates
(_values_last_sent_to_ui) and since 7dac8994f6 to
potential crashes (invalid _controllables[idx]).
This commit is contained in:
Robin Gareus 2024-08-25 15:27:04 +02:00
parent eac3283b49
commit 190cd657b9
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
2 changed files with 28 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gtk2_ardour/lv2_plugin_ui.h
View file

@ -80,7 +80,7 @@ private:
std::shared_ptr<ARDOUR::PlugInsertBase> _pib;
std::shared_ptr<ARDOUR::LV2Plugin> _lv2;
std::vector<int> _output_ports;
std::vector<uint32_t> _output_ports;
sigc::connection _screen_update_connection;
sigc::connection _message_update_connection;
Gtk::Widget* _gui_widget;