smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2026-01-30 08:53:08 +01:00
Code Issues Projects Releases Wiki Activity

Prepare to eventually drop Automatable::value_as_string()

Browse source 
Probably due to historical reasons, there are two APIs to format a
control's value. In all both variants end up calling either
ARDOUR::value_as_string() or the Controllable's formatting function
(except for panners).
This commit is contained in:
Robin Gareus 2017-06-09 13:41:04 +02:00
parent b0f68a0f5c
commit 17fb5bfb49
3 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libs/ardour/ardour/automation_control.h
View file

@ -116,6 +116,8 @@ class LIBARDOUR_API AutomationControl
double internal_to_interface (double i) const;
double interface_to_internal (double i) const;
virtual std::string get_user_string() const;
const ParameterDescriptor& desc() const { return _desc; }
const ARDOUR::Session& session() const { return _session; }

7
libs/ardour/automation_control.cc
View file

@ -31,6 +31,7 @@
#include "ardour/event_type_map.h"
#include "ardour/session.h"
#include "ardour/selection.h"
#include "ardour/value_as_string.h"
#include "pbd/i18n.h"
@ -338,6 +339,12 @@ AutomationControl::interface_to_internal (double val) const
return val;
}
std::string
AutomationControl::get_user_string () const
{
return ARDOUR::value_as_string (_desc, get_value());
}
void
AutomationControl::set_group (boost::shared_ptr<ControlGroup> cg)
{

3
libs/ardour/pannable.cc
View file

@ -28,6 +28,7 @@
#include "ardour/panner.h"
#include "ardour/pan_controllable.h"
#include "ardour/session.h"
#include "ardour/value_as_string.h"
#include "pbd/i18n.h"
@ -282,5 +283,5 @@ Pannable::value_as_string (boost::shared_ptr<const AutomationControl> ac) const
return p->value_as_string (ac);
}
return Automatable::value_as_string (ac);
return ARDOUR::value_as_string(ac->desc(), ac->get_value());
}