smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 08:36:32 +01:00
Code Issues Projects Releases Wiki Activity

Revert "prevent double declicks (click after RecStop)"

Browse source 
This reverts commit 6ba555c2f5.
which does not yet take monitoring states into account.

Ideally the case handled here should not happen in the
first place, It should be fixed in session_transport
transport_sub_state.
This commit is contained in:
Robin Gareus 2015-04-07 15:05:00 +02:00
parent 2bbe4baf29
commit 0ffde76e59
2 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

1
libs/ardour/ardour/route.h
View file

@ -506,7 +506,6 @@ class LIBARDOUR_API Route : public SessionObject, public Automatable, public Rou
framecnt_t _signal_latency_at_amp_position; framecnt_t _signal_latency_at_amp_position;
framecnt_t _initial_delay; framecnt_t _initial_delay;
framecnt_t _roll_delay; framecnt_t _roll_delay;
bool _declicked_silent;
ProcessorList _processors; ProcessorList _processors;
mutable Glib::Threads::RWLock _processor_lock; mutable Glib::Threads::RWLock _processor_lock;

12
libs/ardour/route.cc
View file

@ -83,7 +83,6 @@ Route::Route (Session& sess, string name, Flag flg, DataType default_type)
, _signal_latency_at_amp_position (0) , _signal_latency_at_amp_position (0)
, _initial_delay (0) , _initial_delay (0)
, _roll_delay (0) , _roll_delay (0)
, _declicked_silent (true)
, _flags (flg) , _flags (flg)
, _pending_declick (true) , _pending_declick (true)
, _meter_point (MeterPostFader) , _meter_point (MeterPostFader)
@ -466,18 +465,7 @@ Route::process_output_buffers (BufferSet& bufs,
GLOBAL DECLICK (for transport changes etc.) GLOBAL DECLICK (for transport changes etc.)
----------------------------------------------------------------------------------------- */ ----------------------------------------------------------------------------------------- */
if (_declickable && _declicked_silent && declick <= 0) {
bufs.silence (nframes, 0);
}
maybe_declick (bufs, nframes, declick); maybe_declick (bufs, nframes, declick);
if (declick < 0) {
_declicked_silent = true;
}
else if (declick > 0) {
_declicked_silent = false;
}
_pending_declick = 0; _pending_declick = 0;
/* ------------------------------------------------------------------------------------------- /* -------------------------------------------------------------------------------------------