From 0f3e3b524394474f554d246ed24b704b3a7e9be0 Mon Sep 17 00:00:00 2001
From: Robin Gareus <robin@gareus.org>
Date: Sun, 10 Dec 2023 04:08:30 +0100
Subject: [PATCH] Fix signal emission for Locations::ripple (1/2)

Locations::ripple can never add/remove markers, hence
Locations::changed is not applicable.

That signal is to indicate when more than one location is
added or removed from the location list.
---
 libs/ardour/ardour/location.h | 2 +-
 libs/ardour/location.cc       | 6 +-----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/libs/ardour/ardour/location.h b/libs/ardour/ardour/location.h
index 5d396ca4fa..3e703fd3d4 100644
--- a/libs/ardour/ardour/location.h
+++ b/libs/ardour/ardour/location.h
@@ -277,7 +277,7 @@ public:
 
 	void cut_copy_section (timepos_t const& start, timepos_t const& end, timepos_t const& to, SectionOperation const op);
 
-	void ripple (timepos_t const & at, timecnt_t const & distance, bool include_locked, bool notify);
+	void ripple (timepos_t const & at, timecnt_t const & distance, bool include_locked);
 
 	XMLNode& get_state () const;
 	int set_state (const XMLNode&, int version);
diff --git a/libs/ardour/location.cc b/libs/ardour/location.cc
index 43a8f6a271..4a56a81f98 100644
--- a/libs/ardour/location.cc
+++ b/libs/ardour/location.cc
@@ -1807,7 +1807,7 @@ Locations::range_starts_at (timepos_t const & pos, timecnt_t const & slop, bool
 }
 
 void
-Locations::ripple (timepos_t const & at, timecnt_t const & distance, bool include_locked, bool notify)
+Locations::ripple (timepos_t const & at, timecnt_t const & distance, bool include_locked)
 {
 	LocationList copy;
 
@@ -1846,10 +1846,6 @@ Locations::ripple (timepos_t const & at, timecnt_t const & distance, bool includ
 			(*i)->lock();
 		}
 	}
-
-	if (notify) {
-		changed(); /* EMIT SIGNAL */
-	}
 }
 
 void