smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-09 00:04:56 +01:00
Code Issues Projects Releases Wiki Activity

fix MIDI playlist rendering with opaque regions

Browse source 
regions are sorted lowest-first, not highest-first.
This commit is contained in:
Paul Davis 2025-07-14 09:11:42 -06:00
parent ee4b68fc80
commit 0edba1f559
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
libs/ardour/midi_playlist.cc
View file

@ -357,20 +357,20 @@ MidiPlaylist::render (MidiChannelFilter* filter)
} else { } else {
DEBUG_TRACE (DEBUG::MidiPlaylistIO, string_compose ("\t%1 layered regions to read\n", regs.size())); DEBUG_TRACE (DEBUG::MidiPlaylistIO, string_compose ("\t%1 layered regions to read\n", regs.size()));
bool top = false;
bool top = true;
std::vector<samplepos_t> bounds; std::vector<samplepos_t> bounds;
EventsSortByTimeAndType<samplepos_t> cmp; EventsSortByTimeAndType<samplepos_t> cmp;
int n = regs.size();
/* iterate, bottom region first */
/* iterate, top-most region first */
for (auto & mr : regs) { for (auto & mr : regs) {
DEBUG_TRACE (DEBUG::MidiPlaylistIO, string_compose ("maybe render from %1\n", mr->name())); DEBUG_TRACE (DEBUG::MidiPlaylistIO, string_compose ("maybe render from %1\n", mr->name()));
if (top) { if (--n == 0) {
/* render topmost region as-is */ /* render topmost region as-is */
mr->render (evlist, 0, _note_mode, filter); mr->render (evlist, 0, _note_mode, filter);
top = false;
} else { } else {
Evoral::EventList<samplepos_t> tmp; Evoral::EventList<samplepos_t> tmp;
mr->render (tmp, 0, _note_mode, filter); mr->render (tmp, 0, _note_mode, filter);