smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-11 00:56:33 +01:00
Code Issues Projects Releases Wiki Activity

Some notes for later.

Browse source
This commit is contained in:
Robin Gareus 2017-07-16 16:47:09 +02:00
parent 5aecfc5acb
commit 07aeb12d3a
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
libs/ardour/plugin_insert.cc
View file

@ -1128,7 +1128,13 @@ PluginInsert::bypass (BufferSet& bufs, pframes_t nframes)
void void
PluginInsert::silence (framecnt_t nframes, framepos_t start_frame) PluginInsert::silence (framecnt_t nframes, framepos_t start_frame)
{ {
// XXX This method is never called, Route::silence skips PIs
// we should probably use it during bypass ()
// and call automation_run()
assert (0);
if (!active ()) { if (!active ()) {
// XXX delaybuffers need to be offset by nframes
return; return;
} }
@ -1169,8 +1175,10 @@ PluginInsert::run (BufferSet& bufs, framepos_t start_frame, framepos_t end_frame
} }
} else { } else {
// XXX should call ::silence() to run plugin(s) for consistent load.
// We'll need to change this anyway when bypass can be automated
bypass (bufs, nframes); bypass (bufs, nframes);
automation_run (start_frame, nframes); automation_run (start_frame, nframes); // evaluate automation only
_delaybuffers.flush (); _delaybuffers.flush ();
} }