From 0786ff15a005f6b56a93a5a9a3b486dde4cae725 Mon Sep 17 00:00:00 2001
From: Carl Hetherington <carl@carlh.net>
Date: Mon, 25 Jun 2012 19:26:00 +0000
Subject: [PATCH] Patch from royvegard to add a set-bank midi function (#4949).

git-svn-id: svn://localhost/ardour2/branches/3.0@12927 d708f5d6-7413-0410-9779-e7cbd77b26cf
---
 libs/surfaces/generic_midi/midifunction.cc | 13 ++++++
 libs/surfaces/generic_midi/midifunction.h  |  1 +
 midi_maps/Korg_nanoKONTROL.map             | 52 ++++++++--------------
 3 files changed, 32 insertions(+), 34 deletions(-)

diff --git a/libs/surfaces/generic_midi/midifunction.cc b/libs/surfaces/generic_midi/midifunction.cc
index 302ed0b552..70e9337861 100644
--- a/libs/surfaces/generic_midi/midifunction.cc
+++ b/libs/surfaces/generic_midi/midifunction.cc
@@ -61,6 +61,11 @@ MIDIFunction::setup (GenericMidiControlProtocol& ui, const std::string& invokabl
 		_function = NextBank;
 	} else if (strcasecmp (_invokable_name.c_str(), "prev-bank") == 0) {
 		_function = PrevBank;
+	} else if (strcasecmp (_invokable_name.c_str(), "set-bank") == 0) {
+		if (_argument.empty()) {
+			return -1;
+		}
+		_function = SetBank;
 	} else if (strcasecmp (_invokable_name.c_str(), "select") == 0) {
 		if (_argument.empty()) {
 			return -1;
@@ -95,6 +100,14 @@ MIDIFunction::execute ()
 		_ui->prev_bank();
 		break;
 
+	case SetBank:
+		if (!_argument.empty()) {
+			uint32_t bank;
+			sscanf (_argument.c_str(), "%d", &bank);
+			_ui->set_current_bank (bank);
+		}
+		break;
+
 	case TransportStop:
 		_ui->transport_stop ();
 		break;
diff --git a/libs/surfaces/generic_midi/midifunction.h b/libs/surfaces/generic_midi/midifunction.h
index 8b3a52df3c..8f0b0218d0 100644
--- a/libs/surfaces/generic_midi/midifunction.h
+++ b/libs/surfaces/generic_midi/midifunction.h
@@ -55,6 +55,7 @@ class MIDIFunction : public MIDIInvokable
 		TransportRecordDisable,
 		/* 1 argument functions: RID */
 		Select,
+		SetBank,
 		/* 2 argument functions: RID, value */
 		TrackSetSolo, 
 		TrackSetMute,
diff --git a/midi_maps/Korg_nanoKONTROL.map b/midi_maps/Korg_nanoKONTROL.map
index 17a07f66b0..3acc56891b 100644
--- a/midi_maps/Korg_nanoKONTROL.map
+++ b/midi_maps/Korg_nanoKONTROL.map
@@ -2,44 +2,28 @@
 <ArdourMIDIBindings version="1.0.0" name="Korg nanoKONTROL">
 
 <!-- 2010-11-26 Chooch Schubert: Map file creation -->
-  <DeviceInfo bank-size="9"/>
+  <DeviceInfo bank-size="9" motorized="no" threshold="15"/>
 
 <!-- Transport Controls -->
   <Binding channel="1" ctl="44" function="rec-enable"/>
-  <Binding channel="1" ctl="44" function="rec-disable"/>
+  <Binding channel="1" ctl="46" function="rec-disable"/>
   <Binding channel="1" ctl="45" function="transport-roll"/>
   <Binding channel="1" ctl="46" function="transport-stop"/>
   <Binding channel="1" ctl="47" function="transport-start"/>
   <Binding channel="1" ctl="48" function="transport-end"/>
   <Binding channel="1" ctl="49" function="loop-toggle"/>
 
-<!-- The "Scene" button toggles between four banks. It implements this by   -->
-<!-- changing the midi codes that are sent on each channel control, so when -->
-<!-- you hit the Scene button the nanKONTROL will send different midi codes -->
-<!-- for each button. Scene 1 is faders 1-9, Scene 2 is faders 10-19, etc.  -->
-<!-- This essentially duplicates Ardours Bank feature. Because Ardour is    -->
-<!-- more flexible, I have chosen to map all of the Scene button states to  -->
-<!-- Ardours "next-bank" function.                                          -->
-<!--                                                                        -->
-<!-- The drawback is that the indicator LED may be incorrect in the Scene   -->
-<!-- or Bank number indicated (ie: you could be on Ardour Bank 5, but the   -->
-<!-- LED for Scene 1 will be lit up). If this bother you, then you can      -->
-<!-- comment out the following four lines. This will enable you to use the  -->
-<!-- controllers built in Scenes (possibility of 36 tracks), but you will   -->
-<!-- have to use a mouse to change banks in the Ardour GUI                  -->
-<Binding sysex="f0 42 40 0 1 4 0 5f 4f 0 f7" function="next-bank"/>
-<Binding sysex="f0 42 40 0 1 4 0 5f 4f 1 f7" function="next-bank"/>
-<Binding sysex="f0 42 40 0 1 4 0 5f 4f 2 f7" function="next-bank"/>
-<Binding sysex="f0 42 40 0 1 4 0 5f 4f 3 f7" function="next-bank"/>
+<!-- The "Scene" button toggles between four banks. For this to work as     -->
+<!-- intended, you have to configure all four scenes to be identical.       -->
+<Binding sysex="f0 42 40 0 1 4 0 5f 4f 0 f7" function="set-bank" argument="0"/>
+<Binding sysex="f0 42 40 0 1 4 0 5f 4f 1 f7" function="set-bank" argument="1"/>
+<Binding sysex="f0 42 40 0 1 4 0 5f 4f 2 f7" function="set-bank" argument="2"/>
+<Binding sysex="f0 42 40 0 1 4 0 5f 4f 3 f7" function="set-bank" argument="3"/>
 
 <!--  Channel controls:                                                     -->
 <!--  - The two buttons on each channel are unmarked. I decided to use them -->
 <!--    as "Solo" and "Record Enable".                                      -->
-<!--  - Channel pan is not yet implemented in Ardour-3, so I chose to map   -->
-<!--    the rotary controls as "Send Gain" which will adjust the volume of  -->
-<!--    the first send on each channel, if one exists. When Ardour          -->
-<!--    impliments panning this will likely be changed, since I feel        -->
-<!--    panning is more useful.                                             -->
+<!--  - The rotary controls are bound to pandirection.                      -->
   <Binding channel="1" ctl="2" uri="/route/gain B1"/>
   <Binding channel="1" ctl="3" uri="/route/gain B2"/>
   <Binding channel="1" ctl="4" uri="/route/gain B3"/>
@@ -69,14 +53,14 @@
   <Binding channel="1" ctl="31" uri="/route/solo B9"/>
   <Binding channel="1" ctl="41" uri="/route/recenable B9"/>
 
-  <Binding channel="1" ctl="14" uri="/route/send/gain B1"/>
-  <Binding channel="1" ctl="15" uri="/route/send/gain B2"/>
-  <Binding channel="1" ctl="16" uri="/route/send/gain B3"/>
-  <Binding channel="1" ctl="17" uri="/route/send/gain B4"/>
-  <Binding channel="1" ctl="18" uri="/route/send/gain B5"/>
-  <Binding channel="1" ctl="19" uri="/route/send/gain B6"/>
-  <Binding channel="1" ctl="20" uri="/route/send/gain B7"/>
-  <Binding channel="1" ctl="21" uri="/route/send/gain B8"/>
-  <Binding channel="1" ctl="22" uri="/route/send/gain B9"/>
+  <Binding channel="1" ctl="14" uri="/route/pandirection B1"/>
+  <Binding channel="1" ctl="15" uri="/route/pandirection B2"/>
+  <Binding channel="1" ctl="16" uri="/route/pandirection B3"/>
+  <Binding channel="1" ctl="17" uri="/route/pandirection B4"/>
+  <Binding channel="1" ctl="18" uri="/route/pandirection B5"/>
+  <Binding channel="1" ctl="19" uri="/route/pandirection B6"/>
+  <Binding channel="1" ctl="20" uri="/route/pandirection B7"/>
+  <Binding channel="1" ctl="21" uri="/route/pandirection B8"/>
+  <Binding channel="1" ctl="22" uri="/route/pandirection B9"/>
 
 </ArdourMIDIBindings>