smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-11 17:16:38 +01:00
Code Issues Projects Releases Wiki Activity

warnings: Remove redundant/illegal/undefined-behaviour template-id for constructor

Browse source 
GCC 14 educates us:

	In file included from ../libs/ardour/ardour/io.h:44,
									 from ../libs/ardour/ardour/route.h:50,
									 from ../libs/ardour/ardour/session.h:92,
									 from ../libs/ctrl-interface/midi_surface/midi_surface.cc:30:
	../libs/ardour/ardour/port_set.h:92:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
		 92 |                 iterator_base<PS,P>(PS& list, DataType type, size_t index)
				|                                     ^~
	../libs/ardour/ardour/port_set.h:92:37: note: remove the ‘< >’
This commit is contained in:
Mads Kiilerich 2024-05-05 20:53:14 +02:00 • committed by Robin Gareus
parent 3cb03d9564
commit 0352ff8c5e
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
3 changed files with 18 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
libs/ardour/ardour/midi_buffer.h
View file

@ -71,11 +71,17 @@ public:
class iterator_base
{
public:
iterator_base<BufferType, EventType>(BufferType& b, samplecnt_t o)
: buffer(&b), offset(o) {}
iterator_base (BufferType& b, samplecnt_t o)
: buffer (&b)
, offset (o)
{
}
iterator_base<BufferType, EventType>(const iterator_base<BufferType,EventType>& o)
: buffer (o.buffer), offset(o.offset) {}
iterator_base (const iterator_base<BufferType, EventType>& o)
: buffer (o.buffer)
, offset (o.offset)
{
}
inline iterator_base<BufferType,EventType> operator= (const iterator_base<BufferType,EventType>& o) {
if (&o != this) {

8
libs/ardour/ardour/port_set.h
View file

@ -89,8 +89,12 @@ public:
private:
friend class PortSet;
iterator_base<PS,P>(PS& list, DataType type, size_t index)
: _set(list), _type(type), _index(index) {}
iterator_base (PS& list, DataType type, size_t index)
: _set (list)
, _type (type)
, _index (index)
{
}
PS& _set;
DataType _type; ///< Ignored if NIL (to iterator over entire set)

4
libs/lua/LuaBridge/detail/Userdata.h
View file

@ -361,8 +361,8 @@ template <class T>
class UserdataValue : public Userdata
{
private:
UserdataValue <T> (UserdataValue <T> const&);
UserdataValue <T> operator= (UserdataValue <T> const&);
UserdataValue (UserdataValue<T> const&);
UserdataValue<T> operator= (UserdataValue<T> const&);
char m_storage [sizeof (T)];