smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 08:36:32 +01:00
Code Issues Projects Releases Wiki Activity

Remove custom generic plugin UIs (a-eq) 1/2

Browse source 
Mostly a failed experiment, that also does not play well with
themes. Superseded by Harrison's ACE-EQ GUI.
This commit is contained in:
Robin Gareus 2021-06-04 01:43:01 +02:00
parent bc4ef3ff3d
commit 032aceff28
No known key found for this signature in database
GPG key ID: A090BCE02CF57F04
2 changed files with 1 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

42
gtk2_ardour/generic_pluginui.cc
View file

@ -299,8 +299,6 @@ void
GenericPluginUI::build () GenericPluginUI::build ()
{ {
std::vector<ControlUI *> control_uis; std::vector<ControlUI *> control_uis;
bool grid_avail = false;
bool grid_veto = false;
// Build a ControlUI for each control port // Build a ControlUI for each control port
for (size_t i = 0; i < plugin->parameter_count(); ++i) { for (size_t i = 0; i < plugin->parameter_count(); ++i) {
@ -321,13 +319,6 @@ GenericPluginUI::build ()
const float value = plugin->get_parameter(i); const float value = plugin->get_parameter(i);
ControlUI* cui; ControlUI* cui;
Plugin::UILayoutHint hint;
if (plugin->get_layout(i, hint)) {
grid_avail = true;
} else {
grid_veto = true;
}
boost::shared_ptr<ARDOUR::AutomationControl> c boost::shared_ptr<ARDOUR::AutomationControl> c
= boost::dynamic_pointer_cast<ARDOUR::AutomationControl>( = boost::dynamic_pointer_cast<ARDOUR::AutomationControl>(
@ -339,18 +330,11 @@ GenericPluginUI::build ()
ParameterDescriptor desc; ParameterDescriptor desc;
plugin->get_parameter_descriptor(i, desc); plugin->get_parameter_descriptor(i, desc);
if ((cui = build_control_ui (param, desc, c, value, plugin->parameter_is_input(i), hint.knob)) == 0) { if ((cui = build_control_ui (param, desc, c, value, plugin->parameter_is_input(i))) == 0) {
error << string_compose(_("Plugin Editor: could not build control element for port %1"), i) << endmsg; error << string_compose(_("Plugin Editor: could not build control element for port %1"), i) << endmsg;
continue; continue;
} }
if (grid_avail && !grid_veto) {
cui->x0 = hint.x0;
cui->x1 = hint.x1;
cui->y0 = hint.y0;
cui->y1 = hint.y1;
}
const std::string param_docs = plugin->get_parameter_docs(i); const std::string param_docs = plugin->get_parameter_docs(i);
if (!param_docs.empty()) { if (!param_docs.empty()) {
set_tooltip(cui, param_docs.c_str()); set_tooltip(cui, param_docs.c_str());
@ -360,8 +344,6 @@ GenericPluginUI::build ()
} }
} }
bool grid = grid_avail && !grid_veto;
// Build a ControlUI for each property // Build a ControlUI for each property
const Plugin::PropertyDescriptors& descs = plugin->get_supported_properties(); const Plugin::PropertyDescriptors& descs = plugin->get_supported_properties();
for (Plugin::PropertyDescriptors::const_iterator d = descs.begin(); d != descs.end(); ++d) { for (Plugin::PropertyDescriptors::const_iterator d = descs.begin(); d != descs.end(); ++d) {
@ -403,8 +385,6 @@ GenericPluginUI::build ()
preset_gui = new PluginPresetsUI (insert); preset_gui = new PluginPresetsUI (insert);
hpacker.pack_start (*preset_gui, true, true); hpacker.pack_start (*preset_gui, true, true);
} }
} else if (grid) {
custom_layout (control_uis);
} else { } else {
automatic_layout (control_uis); automatic_layout (control_uis);
} }
@ -635,26 +615,6 @@ GenericPluginUI::automatic_layout (const std::vector<ControlUI*>& control_uis)
} }
void
GenericPluginUI::custom_layout (const std::vector<ControlUI*>& control_uis)
{
Gtk::Table* layout = manage (new Gtk::Table ());
for (vector<ControlUI*>::const_iterator i = control_uis.begin(); i != control_uis.end(); ++i) {
ControlUI* cui = *i;
if (cui->x0 < 0 || cui->y0 < 0) {
continue;
}
layout->attach (*cui, cui->x0, cui->x1, cui->y0, cui->y1, FILL, SHRINK, 2, 2);
}
hpacker.pack_start (*layout, true, true);
if (plugin->has_inline_display () && plugin->inline_display_in_gui ()) {
PluginDisplay* pd = manage (new PluginDisplay (plugin, 300));
hpacker.pack_end (*pd, true, true);
}
}
void void
GenericPluginUI::build_midi_table () GenericPluginUI::build_midi_table ()
{ {

1
gtk2_ardour/plugin_ui.h
View file

@ -291,7 +291,6 @@ private:
void build (); void build ();
void automatic_layout (const std::vector<ControlUI *>& control_uis); void automatic_layout (const std::vector<ControlUI *>& control_uis);
void custom_layout (const std::vector<ControlUI *>& control_uis);
ControlUI* build_control_ui (const Evoral::Parameter& param, ControlUI* build_control_ui (const Evoral::Parameter& param,
const ARDOUR::ParameterDescriptor& desc, const ARDOUR::ParameterDescriptor& desc,