smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-10 08:36:32 +01:00
Code Issues Projects Releases Wiki Activity

snapped pencil drawing of new midi regions cannot be zero (7271).

Browse source 
- fixes a couple of other oddities in the behaviour.
This commit is contained in:
nick_m 2017-03-07 10:36:48 +11:00
parent 7bada83a3f
commit 028b042d2a
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
gtk2_ardour/editor_drag.cc
View file

@ -2426,14 +2426,16 @@ RegionCreateDrag::RegionCreateDrag (Editor* e, ArdourCanvas::Item* i, TimeAxisVi
void void
RegionCreateDrag::motion (GdkEvent* event, bool first_move) RegionCreateDrag::motion (GdkEvent* event, bool first_move)
{ {
if (first_move) { if (first_move) {
_editor->begin_reversible_command (_("create region")); _editor->begin_reversible_command (_("create region"));
_region = add_midi_region (_view, false); _region = add_midi_region (_view, false);
_view->playlist()->freeze (); _view->playlist()->freeze ();
} else { } else {
if (_region) { if (_region) {
framepos_t const f = adjusted_current_frame (event); framepos_t const f = adjusted_current_frame (event);
if (f < grab_frame()) { if (f <= grab_frame()) {
_region->set_initial_position (f); _region->set_initial_position (f);
} }
@ -2443,9 +2445,10 @@ RegionCreateDrag::motion (GdkEvent* event, bool first_move)
a bit confusing as if a region starts 1 frame after a snap point, one cannot a bit confusing as if a region starts 1 frame after a snap point, one cannot
place snapped notes at the start of the region. place snapped notes at the start of the region.
*/ */
if (f != grab_frame()) {
framecnt_t const len = (framecnt_t) fabs ((double)(f - grab_frame () - 1)); framecnt_t const len = (framecnt_t) fabs ((double)(f - grab_frame () - 1));
_region->set_length (len < 1 ? 1 : len, _editor->get_grid_music_divisions (event->button.state)); _region->set_length (len < 1 ? 1 : len, _editor->get_grid_music_divisions (event->button.state));
}
} }
} }
} }