smokephil/ardour
1
0
Fork 0
mirror of https://github.com/Ardour/ardour.git synced 2025-12-09 16:24:57 +01:00
Code Issues Projects Releases Wiki Activity

correct the implementation of BasicUI::button_varispeed() to provide incremental speed shifting (by semitones) in both directions

Browse source
This commit is contained in:
Paul Davis 2021-05-04 16:38:02 -06:00
parent fbd1221833
commit 009e971bfb
1 changed files with 41 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

57
libs/surfaces/control_protocol/basic_ui.cc
View file

@ -188,24 +188,49 @@ BasicUI::remove_marker_at_playhead ()
void void
BasicUI::button_varispeed (bool fwd) BasicUI::button_varispeed (bool fwd)
{ {
// switch play direction, if needed
if (fwd) {
if (get_transport_speed() <= 0) {
session->request_transport_speed (1.0, false);
session->request_roll (TRS_UI);
return ;
}
} else {
if (get_transport_speed() >= 0) {
session->request_transport_speed (-1.0, false);
session->request_roll (TRS_UI);
return;
}
}
// incrementally increase speed by semitones // incrementally increase speed by semitones
// (keypress auto-repeat is 100ms) // (keypress auto-repeat is 100ms)
float maxspeed = Config->get_shuttle_max_speed(); const float maxspeed = Config->get_shuttle_max_speed();
float speed = exp2f(1.0/12.0) * get_transport_speed(); float semitone_ratio = exp2f (1.0f/12.0f);
float transport_speed = get_transport_speed ();
if (transport_speed == 0.0 || fabs (transport_speed) <= 1.0/semitone_ratio) {
/* close to zero, maybe flip direction */
if (fwd) {
if (transport_speed <= 0) {
session->request_transport_speed (1.0, false);
session->request_roll (TRS_UI);
}
} else {
if (transport_speed >= 0) {
session->request_transport_speed (-1.0, false);
session->request_roll (TRS_UI);
}
}
/* either we've just started, or we're moving as slowly as we
* ever should
*/
return;
}
if (fwd) {
if (transport_speed < 0.f) {
/* we need to move the speed back towards zero */
semitone_ratio = 1.0/semitone_ratio;
}
} else {
if (transport_speed > 0.f) {
/* we need to move the speed back towards zero */
semitone_ratio = 1.0/semitone_ratio;
}
}
float speed = semitone_ratio * transport_speed;
speed = std::max (-maxspeed, std::min (maxspeed, speed)); speed = std::max (-maxspeed, std::min (maxspeed, speed));
session->request_transport_speed (speed, false); session->request_transport_speed (speed, false);
session->request_roll (TRS_UI); session->request_roll (TRS_UI);